Retire the Bash forge implementation #157

Merged

vnprc merged 1 commit from agent/retire-bash-forge into master

2026-08-25 00:13:05 +01:00

allod-agent commented

2026-08-25 00:09:52 +01:00

Member

Both deployed Go cutovers have passed: allod-dev and nexus run the same versioned forge-0.1.0 package, with authentication, repository inference, and live snapshots verified. This cleanup deletes the now-dormant Bash executable and its duplicate shell suite; merging it changes no running machine.

The Go command surface and tests remain. allod pr explain now resolves the separately packaged Go forge from PATH, while preserving its explicit test/development override. If this is wrong, revert this commit; the deployed Go package remains independently rollbackable through the existing consumer pins.

Risk

R1, as assigned to the Phase 4 cleanup in the migration plan. The deleted implementation is no longer selected by either deployed consumer. The residual risk is source-checkout use of the removed Bash fallback and the pr-explain resolution change; both are explicit and the latter has fixture plus live dry-run witnesses.

The Go implementation already fixes allod/tools#144 by failing before network access on an empty token and by preserving transport failures during name resolution. Those paths remain pinned in cmd/forge/api_errors_test.go; deleting Bash removes the only implementation that still exhibited the bug.

Validation

host deployment witness on nexus: exact expected versioned package, valid auth, Git repository inference, and live pr snapshot 156
dev deployment witness on allod-dev: same package and smoke checks
nix develop 'path:.' -c: gofmt, go vet ./..., and go test ./...
nix flake check 'path:.'
nix build 'path:.#forge' and built-binary help smoke check
all 704 tests/pr-explain/command.sh assertions, including source-checkout PATH resolution and explicit override precedence
live ./allod pr explain 136 --dry-run from this source tree with no override, proving the installed Go forge PATH fallback
all workspace and tracked-hook shell suites
Bash source/suite absence plus no remaining archetypes or nexus tools/forge consumer

Closes allod/tools#155
Closes allod/tools#144
Refs allod/tools#98

Both deployed Go cutovers have passed: `allod-dev` and `nexus` run the same versioned `forge-0.1.0` package, with authentication, repository inference, and live snapshots verified. This cleanup deletes the now-dormant Bash executable and its duplicate shell suite; merging it changes no running machine. The Go command surface and tests remain. `allod pr explain` now resolves the separately packaged Go `forge` from PATH, while preserving its explicit test/development override. If this is wrong, revert this commit; the deployed Go package remains independently rollbackable through the existing consumer pins. ## Risk R1, as assigned to the Phase 4 cleanup in the migration plan. The deleted implementation is no longer selected by either deployed consumer. The residual risk is source-checkout use of the removed Bash fallback and the `pr-explain` resolution change; both are explicit and the latter has fixture plus live dry-run witnesses. The Go implementation already fixes allod/tools#144 by failing before network access on an empty token and by preserving transport failures during name resolution. Those paths remain pinned in `cmd/forge/api_errors_test.go`; deleting Bash removes the only implementation that still exhibited the bug. ## Validation - host deployment witness on `nexus`: exact expected versioned package, valid auth, Git repository inference, and live `pr snapshot 156` - dev deployment witness on `allod-dev`: same package and smoke checks - `nix develop 'path:.' -c`: `gofmt`, `go vet ./...`, and `go test ./...` - `nix flake check 'path:.'` - `nix build 'path:.#forge'` and built-binary help smoke check - all 704 `tests/pr-explain/command.sh` assertions, including source-checkout PATH resolution and explicit override precedence - live `./allod pr explain 136 --dry-run` from this source tree with no override, proving the installed Go `forge` PATH fallback - all workspace and tracked-hook shell suites - Bash source/suite absence plus no remaining archetypes or nexus `tools/forge` consumer Closes allod/tools#155 Closes allod/tools#144 Refs allod/tools#98

allod-agent added 1 commit

2026-08-25 00:09:52 +01:00