forge reports an error but keeps going: empty token file still hits the network; name resolution reports 'not found' after a transport failure #144

New issue

Closed

opened 2026-08-19 03:52:25 +01:00 by allod-agent · 0 comments

allod-agent commented

2026-08-19 03:52:25 +01:00

Member

forge sometimes prints an error that reads as fatal and then continues executing, producing a second, misleading outcome: an empty token file still leads to an API request, and a label or milestone name lookup that fails at the transport level is reported as the name not existing.

Evidence

Empty token file — the "is empty" error does not stop the run; the API call is still attempted (and with a real server would be sent without a usable token):

$ T=$(mktemp); : > "$T"
$ env -u FORGEJO_TOKEN FORGE_TOKEN_FILE="$T" FORGE_URL=http://127.0.0.1:9 forge label list -R own/repo
forge: /tmp/tmp.T1P2WQhm4K is empty
forge: GET /repos/own/repo/labels?limit=30 failed: curl exit 7
exit: 7

Name-based label resolution — the lookup GET fails at the transport level, but the run continues and misreports the failure as the label not existing (exit 1, not the transport code):

$ env FORGEJO_TOKEN=dummytok FORGE_URL=http://127.0.0.1:9 forge label edit somename -d x -R own/repo
forge: GET /repos/own/repo/labels?limit=100 failed: curl exit 7
forge: label not found: somename
exit: 1

Milestone name resolution shows the same symptom:

$ env FORGEJO_TOKEN=dummytok FORGE_URL=http://127.0.0.1:9 forge milestone view sometitle -R own/repo
forge: GET /repos/own/repo/milestones?state=all&name=sometitle&limit=100 failed: curl exit 7
forge: milestone not found: sometitle
exit: 1

Numeric-ID targets are unaffected (no name lookup happens). Observed on the current master forge (commit d6a0612) on a dev VM.

`forge` sometimes prints an error that reads as fatal and then continues executing, producing a second, misleading outcome: an empty token file still leads to an API request, and a label or milestone name lookup that fails at the transport level is reported as the name not existing. ### Evidence Empty token file — the "is empty" error does not stop the run; the API call is still attempted (and with a real server would be sent without a usable token): ``` $ T=$(mktemp); : > "$T" $ env -u FORGEJO_TOKEN FORGE_TOKEN_FILE="$T" FORGE_URL=http://127.0.0.1:9 forge label list -R own/repo forge: /tmp/tmp.T1P2WQhm4K is empty forge: GET /repos/own/repo/labels?limit=30 failed: curl exit 7 exit: 7 ``` Name-based label resolution — the lookup GET fails at the transport level, but the run continues and misreports the failure as the label not existing (exit 1, not the transport code): ``` $ env FORGEJO_TOKEN=dummytok FORGE_URL=http://127.0.0.1:9 forge label edit somename -d x -R own/repo forge: GET /repos/own/repo/labels?limit=100 failed: curl exit 7 forge: label not found: somename exit: 1 ``` Milestone name resolution shows the same symptom: ``` $ env FORGEJO_TOKEN=dummytok FORGE_URL=http://127.0.0.1:9 forge milestone view sometitle -R own/repo forge: GET /repos/own/repo/milestones?state=all&name=sometitle&limit=100 failed: curl exit 7 forge: milestone not found: sometitle exit: 1 ``` Numeric-ID targets are unaffected (no name lookup happens). Observed on the current master `forge` (commit d6a0612) on a dev VM.

allod-agent added the

bug

label

2026-08-19 03:52:25 +01:00

allod-agent referenced this issue

2026-08-19 05:16:45 +01:00

forge: Go reimplementation of the forge CLI (bash-to-Go Phase 1) #145

allod-agent referenced this issue

2026-08-24 21:09:12 +01:00

Finish the Go forge cutover: close the snapshot drift, then deploy and retire the bash tool #155

allod-agent referenced this issue from a pull request that will close it,

2026-08-25 00:09:52 +01:00