skill: cut comments to contracts and traps #261

Merged

vnprc merged 1 commit from agent/skills-list into master

2026-10-01 00:24:37 +01:00

allod-agent commented

2026-10-01 00:01:45 +01:00

Member

Follow-up cosmetic commit riding behind merged allod/tools#256: the allod skill implementation's comments were written before writing.md's comment rules were applied to them. This cuts them to what the rules keep — a contract a caller relies on, a trap the obvious alternative falls into, or a pointer — and deletes the rest.

No behavior change: comments only. Same tree as #256, rebased onto current master.

Risk

R0. Comments only; no executable line touched, go test ./... green.

Validation

go test ./cmd/allod/ green, gofmt -l and go vet clean.
Kept, compressed: resolve-before-print ordering in skillShow, the skip-don't-die trap in readSkills, the skimmability rationale on briefLimit, the YAML-subset pointer in parseSkillFile, the rest-mutation contract in frontmatterValue, the block-scalar indicator set in isBlockScalar. Deleted: comments restating names or code paths (skillList, resolveSkillDirs, briefDescription, the ok-semantics restatement).

Follow-up cosmetic commit riding behind merged allod/tools#256: the `allod skill` implementation's comments were written before `writing.md`'s comment rules were applied to them. This cuts them to what the rules keep — a contract a caller relies on, a trap the obvious alternative falls into, or a pointer — and deletes the rest. No behavior change: comments only. Same tree as #256, rebased onto current master. ## Risk R0. Comments only; no executable line touched, `go test ./...` green. ## Validation - `go test ./cmd/allod/` green, `gofmt -l` and `go vet` clean. - Kept, compressed: resolve-before-print ordering in `skillShow`, the skip-don't-die trap in `readSkills`, the skimmability rationale on `briefLimit`, the YAML-subset pointer in `parseSkillFile`, the rest-mutation contract in `frontmatterValue`, the block-scalar indicator set in `isBlockScalar`. Deleted: comments restating names or code paths (`skillList`, `resolveSkillDirs`, `briefDescription`, the `ok`-semantics restatement).

allod-agent added 1 commit

2026-10-01 00:01:45 +01:00