pm: point the issue-review prompt at the nested allod/memory checkout #121

Merged

vnprc merged 1 commit from agent/pm-issue-writing-path into master

2026-07-28 00:04:25 +01:00

allod-agent commented

2026-07-27 23:55:50 +01:00

Member

allod pm review rewrote the issue-writing memory reference in the pm-issue-review skill into ${WORK_DIR:-$HOME/work}/allod-memory/issue-writing.md, a flat path that predates the nested checkout layout and does not exist on a current dev VM. The substitution now emits ${WORK_DIR:-$HOME/work}/allod/memory/issue-writing.md, matching the checkout the repository registry produces for allod/memory.

Despite the issue title, the broken substitution is in the pm review path (pm/pm:137), not the groom prompt — the location named in the issue body. The groom skill's own reference to the issue-writing shape is left as the logical allod/memory issue-writing.md and is never rewritten, so it was not affected.

Swept the rest of pm/ for other flat allod-<repo> path assumptions: none. The remaining allod- hits in pm/skills/pm-issue-review/SKILL.md are all prose uses of "allod-org", not paths.

Risk

Low. One sed replacement string in a prompt-construction pipeline; no control flow, no forge writes, no state-repo behavior changed. Worst case if wrong, the review agent is pointed at a different missing file — the same failure mode as today, not a new one.

Validation

bash -n pm/pm passes.
Ran the awk | sed prompt pipeline against pm/skills/pm-issue-review/SKILL.md and confirmed the rewritten line reads /home/allod/work/allod/memory/issue-writing.md, and that the file exists at that path.
Confirmed allod/inventory/scripts/repositories.json maps allod/memory to checkout allod/memory.

Not covered: pm/ has no test suite in tests/, so there is no regression test pinning this path. Adding a pm test harness was left out of scope.

Closes allod/tools#120

`allod pm review` rewrote the issue-writing memory reference in the `pm-issue-review` skill into `${WORK_DIR:-$HOME/work}/allod-memory/issue-writing.md`, a flat path that predates the nested checkout layout and does not exist on a current dev VM. The substitution now emits `${WORK_DIR:-$HOME/work}/allod/memory/issue-writing.md`, matching the `checkout` the repository registry produces for `allod/memory`. Despite the issue title, the broken substitution is in the `pm review` path (`pm/pm:137`), not the groom prompt — the location named in the issue body. The groom skill's own reference to the issue-writing shape is left as the logical `allod/memory issue-writing.md` and is never rewritten, so it was not affected. Swept the rest of `pm/` for other flat `allod-<repo>` path assumptions: none. The remaining `allod-` hits in `pm/skills/pm-issue-review/SKILL.md` are all prose uses of "allod-org", not paths. ## Risk Low. One `sed` replacement string in a prompt-construction pipeline; no control flow, no forge writes, no state-repo behavior changed. Worst case if wrong, the review agent is pointed at a different missing file — the same failure mode as today, not a new one. ## Validation - `bash -n pm/pm` passes. - Ran the `awk | sed` prompt pipeline against `pm/skills/pm-issue-review/SKILL.md` and confirmed the rewritten line reads `/home/allod/work/allod/memory/issue-writing.md`, and that the file exists at that path. - Confirmed `allod/inventory/scripts/repositories.json` maps `allod/memory` to checkout `allod/memory`. Not covered: `pm/` has no test suite in `tests/`, so there is no regression test pinning this path. Adding a pm test harness was left out of scope. Closes allod/tools#120

allod-agent added 1 commit

2026-07-27 23:55:50 +01:00