Add the runtime-selected guest module plan #26

Merged

vnprc merged 3 commits from agent/runtime-guest-module-selection into master

2026-07-31 06:15:39 +01:00

allod-agent commented

2026-07-31 04:52:55 +01:00

Member

Adds the dev plan and review prompt for allod/archetypes#22, a scoped slice of milestone 4 in microvm-framework-adoption.md implementing that plan's contract 2 only.

The plan exists because the issue as written could not be implemented directly: inventory.lib.vmRuntimes does not exist, the issue's out-of-scope volume declarations contradict its own microvm validation criterion, and two flake input bumps are unstated prerequisites. The plan resolves each and records the corrections so the issue can be fixed rather than implemented as written.

Refs allod/strategy#20
Refs allod/archetypes#22

Risk

R0. Documentation only — a dev plan and its review prompt. The work it describes is allod/archetypes#23, which carries its own R2 assessment.

Validation

Reviewed by gpt-5.6-sol at high effort, a cross-vendor rotation from the Opus-authored draft. Three high findings and one medium, all confirmed against the tree before folding:

The fleet assertion covered nexus, which composes no guest module and does not declare the marker option — verified that reading it errors.
Fixtures built as standalone nixosSystem calls would have exercised a fixture helper rather than the production selector, so the check could have passed while the builder stayed hard-coded.
Reading the marker does not force NixOS module assertions, so a microvm fixture could have reported success with allod/vm's volume contract unevaluated.
Archetypes cannot re-prove inventory's enum diagnostics locally; they are lexical internals and a downstream override lands after the trip-wire.

The reviewer's proposed fix for the second finding — whole machine records plus a machineConfigurationsFor constructor — was rejected as ceremony. One optional argument reaches the same code path and matches the builder's existing idiom. The evidence table in the review prompt records that.

Implementation confirmed all four fixes hold: allod/archetypes#23 is green on 10 checks with the fleet derivations unchanged.

Adds the dev plan and review prompt for allod/archetypes#22, a scoped slice of milestone 4 in `microvm-framework-adoption.md` implementing that plan's contract 2 only. The plan exists because the issue as written could not be implemented directly: `inventory.lib.vmRuntimes` does not exist, the issue's out-of-scope volume declarations contradict its own microvm validation criterion, and two flake input bumps are unstated prerequisites. The plan resolves each and records the corrections so the issue can be fixed rather than implemented as written. Refs allod/strategy#20 Refs allod/archetypes#22 ## Risk R0. Documentation only — a dev plan and its review prompt. The work it describes is allod/archetypes#23, which carries its own R2 assessment. ## Validation Reviewed by `gpt-5.6-sol` at `high` effort, a cross-vendor rotation from the Opus-authored draft. Three high findings and one medium, all confirmed against the tree before folding: - The fleet assertion covered `nexus`, which composes no guest module and does not declare the marker option — verified that reading it errors. - Fixtures built as standalone `nixosSystem` calls would have exercised a fixture helper rather than the production selector, so the check could have passed while the builder stayed hard-coded. - Reading the marker does not force NixOS module assertions, so a microvm fixture could have reported success with allod/vm's volume contract unevaluated. - Archetypes cannot re-prove inventory's enum diagnostics locally; they are lexical internals and a downstream override lands after the trip-wire. The reviewer's proposed fix for the second finding — whole machine records plus a `machineConfigurationsFor` constructor — was rejected as ceremony. One optional argument reaches the same code path and matches the builder's existing idiom. The evidence table in the review prompt records that. Implementation confirmed all four fixes hold: `allod/archetypes#23` is green on 10 checks with the fleet derivations unchanged.

allod-agent added 3 commits

2026-07-31 04:52:55 +01:00