Refresh stale find-by-head reference in bash-to-go migration plan #19

Merged

vnprc merged 1 commit from agent/refresh-find-by-head-refs into master

2026-07-20 15:29:38 +01:00

allod-agent commented

2026-07-20 15:20:34 +01:00

Member

Refreshes the one stale reference to forge pr find-by-head that remained after allod/tools#83 fixed the head-filter bug, so pr_find_by_head and resolve_pr_target now match head.ref client-side.

Change

dev-plans/bash-to-go-migration.md listed allod/tools#83 (find-by-head head-filter) as an example of an open correctness bug the Go port must fix, add a test for, and enumerate in its PR body. That note predates the fix (plan written 2026-07-11; fix landed 2026-07-17). Because the migration freezes behavior at current bash and the bug is now fixed in bash, the Go port inherits the fix through ordinary parity — the "divergence" framing would send future migration work chasing a bug that no longer exists. Reworded the divergence rule to apply to bugs still open at port time and noted #83 as already fixed.

Audit (issue #109 scope)

Full workspace sweep for the stale claims and workaround guidance #109 describes:

Agent memory (allod/memory): already clean — no "broken find-by-head" claim and no stacked-PR workaround. No change needed.
allod/tools/docs/forge.md: already describes find-by-head correctly ("print PR number if open PR exists for branch"). No change needed.
allod/tools code (forge, allod): carries the #83 fix; the PR #<n> already exists for '<branch>' message is correct current behavior. Out of scope — #109 is doc/memory only.
Stacked-PR workaround ("create the second PR with forge pr create -H … -B … directly"): appears only in the #83 bug report itself, not in any note or memory. Nothing to remove.
Remaining stale reference: the migration-plan divergence-rule example above — corrected here.

Risk

Doc-only change to an active dev plan; no tooling or generated behavior affected. The divergence rule is preserved for genuinely open bugs.

Validation

Re-grepped the workspace for find-by-head, find_by_head, stacked, and PR already exists after the edit; the only remaining hits are correct code, tests, and accurate command-contract descriptions in docs/forge.md and the migration plan's Interface Contracts.

Closes allod/tools#109

Refreshes the one stale reference to `forge pr find-by-head` that remained after allod/tools#83 fixed the head-filter bug, so `pr_find_by_head` and `resolve_pr_target` now match `head.ref` client-side. ## Change `dev-plans/bash-to-go-migration.md` listed allod/tools#83 (find-by-head head-filter) as an example of an *open* correctness bug the Go port must fix, add a test for, and enumerate in its PR body. That note predates the fix (plan written 2026-07-11; fix landed 2026-07-17). Because the migration freezes behavior at current bash and the bug is now fixed in bash, the Go port inherits the fix through ordinary parity — the "divergence" framing would send future migration work chasing a bug that no longer exists. Reworded the divergence rule to apply to bugs still open at port time and noted #83 as already fixed. ## Audit (issue #109 scope) Full workspace sweep for the stale claims and workaround guidance #109 describes: - Agent memory (`allod/memory`): already clean — no "broken find-by-head" claim and no stacked-PR workaround. No change needed. - `allod/tools/docs/forge.md`: already describes `find-by-head` correctly ("print PR number if open PR exists for branch"). No change needed. - `allod/tools` code (`forge`, `allod`): carries the #83 fix; the `PR #<n> already exists for '<branch>'` message is correct current behavior. Out of scope — #109 is doc/memory only. - Stacked-PR workaround ("create the second PR with `forge pr create -H … -B …` directly"): appears only in the #83 bug report itself, not in any note or memory. Nothing to remove. - Remaining stale reference: the migration-plan divergence-rule example above — corrected here. ## Risk Doc-only change to an active dev plan; no tooling or generated behavior affected. The divergence rule is preserved for genuinely open bugs. ## Validation Re-grepped the workspace for `find-by-head`, `find_by_head`, `stacked`, and `PR already exists` after the edit; the only remaining hits are correct code, tests, and accurate command-contract descriptions in `docs/forge.md` and the migration plan's Interface Contracts. Closes allod/tools#109

allod-agent added 1 commit

2026-07-20 15:20:35 +01:00