Drop the machine-coverage check; the framework runs it now #49
No reviewers
Labels
No labels
blocked
bug
decision
duplicate
enhancement
handoff
help wanted
invalid
landed?
question
ready-to-merge
stale
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
allod/secrets!49
Loading…
Reference in a new issue
No description provided.
Delete branch "agent/drop-machine-coverage"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Nothing changes on any running machine. The template drops its copy of the
machine-coveragecheck, because the same check now lives in the framework (allod/archetypes#148) and runs in every deployment's gate against that deployment's own data, which the copy here never could: a deployment builds from a private fork of this repo, and the fork never took the template's checks. Under the deletion rule a check goes when a cheaper witness pins the same property. What stays identical: every data file, everyliboutput, the other nine checks. Proof: the gate on this branch isAll 10 steps passed (checks: 9 built)and nothing in the tree references the check. Merge order: after the archetypes pull request has landed, so no gate is ever without the check. If it is wrong, revert the one commit and the template copy is back.Closes allod/archetypes#148
Risk
R0. Deletes a check and its two references; no data, output or runtime behavior changes.
Validation
allod check .on the branch:All 10 steps passed (checks: 9 built), no step namedmachine-coverage.git diff --stat HEAD~1: exactlyREADME.md,checks/default.nix,checks/machine-coverage.nix.grep -rn machine-coverage README.md checks/finds nothing.