Record the fork-safe check rule and its witness #61
No reviewers
Labels
No labels
blocked
bug
decision
duplicate
enhancement
help wanted
invalid
landed?
question
ready-to-merge
stale
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
allod/memory!61
Loading…
Reference in a new issue
No description provided.
Delete branch "agent/fork-safe-check-rule"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Records the check rule that allod/archetypes#88 enforces, so the next session writing a framework check meets it before it writes one that only works on the template.
Three things go into
testing.md, beside the narrower "do not name a real machine in a fixture" rule it already carries:${secrets}/git/protected-branches— while its names are not. Without that line the rule reads as condemning working production paths.machineConfigurationsmergesprofileDatainto builder arguments, so a parameter added so a check can drive a builder is also a key the profiles layer can set. That cost was found by review, not by design, which is why it is worth writing down.Plus a pointer to the standing witness, and the one thing that makes such a witness stop working: tuning the fixture data until a check passes.
No line is proposed for
memory.md; this belongs to the topic file that owns check policy, and the index takes a line only on two sightings.Refs allod/archetypes#88
Corrected one sentence: the fork-safety cadence no longer claims a memory reason that has since been measured away.
The paragraph said the witness runs on the lock-bump path because a second pass would double a run already peaking near the memory ceiling. That was true of the whole-flake gate this repo used to describe. allod/archetypes#31 has since split the gate to one process per step and measured it — about 80 s, largest single process 1.7 GiB — and allod/memory#65 already corrected nix.md to match. The sentence now states the cadence and stops arguing for it.
Worth flagging for whoever reads this: the same measurement weakens the original case for the witness being lock-bump-only at all. A second full pass now costs roughly another 80 s with no memory risk, since only one process runs at a time. Whether it should become a per-commit gate is a real question that measurement reopened, and it belongs in an archetypes issue rather than in this paragraph.
111dbaf01dtof11e98ab9df11e98ab9dtoabe375bc32