Review budget: plans and document review for R4 only, one reviewer for R2/R3

allod-agent commented

2026-09-12 01:58:00 +01:00

Member

This changes how much review process an agent runs, not anything on a machine. Dev plans and their review-prompt loop become an R4-only tool; R0 through R3 work is specified by the tracking issue and reviewed as code through the PR. The review budget per PR becomes: none for R0/R1, one cold cross-family reviewer plus one fix round for R2/R3, two reviewers for R4, and every PR is scored on its own rather than inheriting its arc's score. The overseer in delegate-implementation reads the gate output and the reviewer's findings, not every diff in full, and workers commit locally so packaged checks can run. The plan-review-prompt template is deleted; the dev-plan template stays for R4. Nothing here touches code, generated behavior, or secrets; if it is wrong, revert it and the previous process text is back.

What changes

dev-plans.md: a plan is written only for R4 work or irreversible cross-repo cutover choreography; plan review is an R4 activity requested by PR comment, with evidence in the PR body; agent-rotation and review-evidence sections trimmed to match; the model pool is stated to serve code reviews.
risk.md: the pass budget is per PR, never per arc; R0/R1 no reviewer, R2/R3 one reviewer and one fix round, R4 two reviewers plus a plan reviewed as a document.
memory.md: delegate-implementation triggers on multi-repo or R3+ work; the PR Workflow bullet carries the new budget.
skills/delegate-implementation/SKILL.md: reviewer count follows risk.md; one fix round, then tests settle findings; the overseer does not re-read every diff or spawn audits that a diffstat already answers; workers commit locally, never push.
templates/plan-review-prompt.md deleted; README.md and allod.md references updated.

Risk

R0. Process text only.

Validation

git diff --check: clean.
Motivation: the credential-value-templates arc (allod/secrets#23) spent a plan review pass on prose that the issue already held, while the defects that mattered were found only by code reviews; two reviewers per slice plus fix rounds doubled the cost of each PR. The owner asked for the lighter process this PR records.

This changes how much review process an agent runs, not anything on a machine. Dev plans and their review-prompt loop become an R4-only tool; R0 through R3 work is specified by the tracking issue and reviewed as code through the PR. The review budget per PR becomes: none for R0/R1, one cold cross-family reviewer plus one fix round for R2/R3, two reviewers for R4, and every PR is scored on its own rather than inheriting its arc's score. The overseer in `delegate-implementation` reads the gate output and the reviewer's findings, not every diff in full, and workers commit locally so packaged checks can run. The plan-review-prompt template is deleted; the dev-plan template stays for R4. Nothing here touches code, generated behavior, or secrets; if it is wrong, revert it and the previous process text is back. ## What changes - `dev-plans.md`: a plan is written only for R4 work or irreversible cross-repo cutover choreography; plan review is an R4 activity requested by PR comment, with evidence in the PR body; agent-rotation and review-evidence sections trimmed to match; the model pool is stated to serve code reviews. - `risk.md`: the pass budget is per PR, never per arc; R0/R1 no reviewer, R2/R3 one reviewer and one fix round, R4 two reviewers plus a plan reviewed as a document. - `memory.md`: `delegate-implementation` triggers on multi-repo or R3+ work; the PR Workflow bullet carries the new budget. - `skills/delegate-implementation/SKILL.md`: reviewer count follows `risk.md`; one fix round, then tests settle findings; the overseer does not re-read every diff or spawn audits that a diffstat already answers; workers commit locally, never push. - `templates/plan-review-prompt.md` deleted; `README.md` and `allod.md` references updated. ## Risk R0. Process text only. ## Validation - `git diff --check`: clean. - Motivation: the credential-value-templates arc (allod/secrets#23) spent a plan review pass on prose that the issue already held, while the defects that mattered were found only by code reviews; two reviewers per slice plus fix rounds doubled the cost of each PR. The owner asked for the lighter process this PR records.

allod-agent added 1 commit

2026-09-12 01:58:00 +01:00

Review budget: plans and document review for R4 only, one reviewer for R2/R3 319b39cfe3

Dev plans and the review-prompt loop become an R4-only tool; R0 through
R3 work is specified by the tracking issue and reviewed as code. Each PR
is scored on its own, gets no reviewer at R0/R1, one cold cross-family
reviewer and one fix round at R2/R3, and two reviewers at R4. The
overseer reads gate output and reviewer findings rather than every diff;
workers commit locally. The plan-review-prompt template is deleted.

vnprc merged commit 319b39cfe3 into master

2026-09-12 02:33:27 +01:00

vnprc deleted branch agent/process-review-budget

2026-09-12 02:33:27 +01:00

Rows
Columns

Review budget: plans and document review for R4 only, one reviewer for R2/R3 #55

What changes

Risk

Validation