Mark host-provided repos per machine and render them into vm-specs.json #22
No reviewers
Labels
No labels
blocked
bug
decision
duplicate
enhancement
help wanted
invalid
landed?
question
ready-to-merge
stale
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
allod/inventory!22
Loading…
Reference in a new issue
No description provided.
Delete branch "agent/host-provided-marker"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A machine definition may now list repos the hypervisor supplies instead of the guest cloning them, as
host_provided_repos. For a running machine nothing changes: no public machine declares the marker,scripts/vm-specs.jsonis byte-identical, and every consumer that does not read the new key sees the same JSON. What proves it: the existingvm-specs-jsondrift check still passes, and a newhost-provided-repos-mutationscheck pins each malformed marker (not a list of strings, a member outsiderepos, declared on a hypervisor) to its own evaluation failure and shows a valid marker reaching the generated spec. If it is wrong, revert the commit; nothing on disk or in a deployment depends on it untilallod/nexusreads the key.Closes allod/inventory#21
Refs allod/strategy#62
Risk
R3 by the walk: this is a cross-repo interface (
allod/nexus#73reads the key), but the worst credible failure after validation is a fork declaring a malformed marker and getting a named evaluation failure, with no generated artifact or machine affected. Rollback is a straight revert.Validation
nix eval --raw .#lib.vmSpecsJson | jq -S . | diff - <(jq -S . scripts/vm-specs.json): identical.allod check: all 8 steps passed (6 checks built), including the new mutation check.hostProvidedNotInRepospredicate disabled, the new check failed on its two member-outside-repos assertions; restored, green.