Replace check.sh with allod check #117

Merged

vnprc merged 1 commit from agent/allod-check-gate into master

2026-09-28 14:58:46 +01:00

allod-agent commented

2026-09-28 03:33:12 +01:00

Member

Owner summary

What changes on a running machine: nothing. No machine builds or runs the files touched here.
What changes for whoever checks this repository: ./check.sh and ./check-selftest.sh are gone. The command is allod check, from allod/tools.
A machine needs tools that carry the command. This repository still pins allod/tools at a revision from before it existed. Until that pin is bumped and a machine is rebuilt, allod check is not installed there, and the way to run the gate is a build of current allod/tools.
What stays identical: the steps that run. The command passes the same 31 steps and builds the same 18 checks as check.sh did. flake.nix, flake.lock, every module and every check are untouched, and fork-safety.sh does what it did.
What proves it: the gate run on this branch, below.
If it is wrong: revert this PR; the scripts come back as they were.

Refs allod/tools#239

What changed

792 lines removed, 29 added.

check.sh and check-selftest.sh deleted.
allod-check.toml added, one line: the four outputs this repository exposes beyond what the command allows by itself (profilesSource, secretsSource, inventorySource, secretsConsumedInventorySource).
README.md: the two paragraphs describing the scripts become one that names the command and points at docs/allod-check.md in allod/tools.
Comments in fork-safety.sh, fork-safety-selftest.sh and checks/default.nix that named the deleted scripts are reworded. No line of code in them changed.

Risk

R1. Documentation, comments, and the removal of two scripts nothing else calls.

What this repository no longer holds: the proof that the gate can fail. That is now tests/allod-check-selftest.sh in allod/tools, run by hand after a Nix upgrade and before a change to the command.

Validation

Run by the integrator on cb7335e, with allod built from allod/tools at 745c78b:

Command	Result
`allod check`	exit 0, "All 31 steps passed (checks: 18 built)", 79 s, `flake.lock` unchanged
`grep -rn 'check\.sh\|check-selftest' . \| grep -v fork-safety`	no output
Changed lines in `fork-safety.sh`, `fork-safety-selftest.sh`, `checks/default.nix` that are not comments	none
`bash -n fork-safety.sh`, `bash -n fork-safety-selftest.sh`	ok

Not run: fork-safety.sh itself, which this change touches in comments only.

No review pass: R1.

## Owner summary - **What changes on a running machine:** nothing. No machine builds or runs the files touched here. - **What changes for whoever checks this repository:** `./check.sh` and `./check-selftest.sh` are gone. The command is `allod check`, from `allod/tools`. - **A machine needs tools that carry the command.** This repository still pins `allod/tools` at a revision from before it existed. Until that pin is bumped and a machine is rebuilt, `allod check` is not installed there, and the way to run the gate is a build of current `allod/tools`. - **What stays identical:** the steps that run. The command passes the same 31 steps and builds the same 18 checks as `check.sh` did. `flake.nix`, `flake.lock`, every module and every check are untouched, and `fork-safety.sh` does what it did. - **What proves it:** the gate run on this branch, below. - **If it is wrong:** revert this PR; the scripts come back as they were. Refs allod/tools#239 ## What changed 792 lines removed, 29 added. - `check.sh` and `check-selftest.sh` deleted. - `allod-check.toml` added, one line: the four outputs this repository exposes beyond what the command allows by itself (`profilesSource`, `secretsSource`, `inventorySource`, `secretsConsumedInventorySource`). - `README.md`: the two paragraphs describing the scripts become one that names the command and points at `docs/allod-check.md` in `allod/tools`. - Comments in `fork-safety.sh`, `fork-safety-selftest.sh` and `checks/default.nix` that named the deleted scripts are reworded. No line of code in them changed. ## Risk R1. Documentation, comments, and the removal of two scripts nothing else calls. What this repository no longer holds: the proof that the gate can fail. That is now `tests/allod-check-selftest.sh` in `allod/tools`, run by hand after a Nix upgrade and before a change to the command. ## Validation Run by the integrator on `cb7335e`, with `allod` built from `allod/tools` at `745c78b`: | Command | Result | | --- | --- | | `allod check` | exit 0, "All 31 steps passed (checks: 18 built)", 79 s, `flake.lock` unchanged | | `grep -rn 'check\.sh\|check-selftest' . \| grep -v fork-safety` | no output | | Changed lines in `fork-safety.sh`, `fork-safety-selftest.sh`, `checks/default.nix` that are not comments | none | | `bash -n fork-safety.sh`, `bash -n fork-safety-selftest.sh` | ok | Not run: `fork-safety.sh` itself, which this change touches in comments only. No review pass: R1.

allod-agent added 1 commit

2026-09-28 03:33:12 +01:00

Delete the check gate scripts for the tools command cb7335e84e

`allod check` in allod/tools does what `check.sh` did, and its own
self-test does what `check-selftest.sh` did, so both scripts go. The four
top-level outputs the command is allowed to force here move to
`allod-check.toml`; `lib` and `vmFacts` are built into the command and
are not listed.

The README's Common commands section and the remaining comments name the
command instead of the deleted scripts. What `fork-safety.sh` does is
unchanged; only its comments are reworded.

Refs allod/tools#239