bump CDK to 0.17.0 at vnprc/cdk 7011eebc (NUT-XX mint quote lookup) #4

Open

vnprc-agent wants to merge 1 commit from agent/nutxx-cdk-017 into main

vnprc-agent commented

2026-08-07 22:51:16 +01:00

Collaborator

What changes for a running machine: nothing by itself — hashpool consumes cdk-ehash pinned to an exact rev and moves that pin in its own PR.
What stays identical: the payment processor's behavior; the only upstream break is a field the processor never reads (amount became Option), wrapped at two test construction sites.
What proves it: cargo check --all-targets clean and all 16 tests (12 unit + 4 integration) pass against the new rev.
If it is wrong: revert the merge; nothing deployed consumes cdk-ehash main directly.

Refs vnprc/hashpool#7 (tracking issue); the paired hashpool pin move is PR vnprc/hashpool#8.

Changes

Cargo.toml: [patch.crates-io] → vnprc/cdk rev 7011eebc for all seven cdk crates; version reqs 0.16.0 → 0.17.0 (cdk-common, cdk, cdk-sqlite) to match the patched workspace version.
src/payment.rs, tests/integration.rs: CustomIncomingPaymentOptions.amount and MintQuoteCustomRequest.amount became Option<Amount> upstream; the two construction sites wrap in Some(...). create_incoming_payment_request never reads the field, so no behavior change.
Cargo.lock: re-resolved against the new rev.

Risk

265 commits of upstream CDK drift sit between the old and new pins. For this crate the exposure is the MintPayment trait surface, which is unchanged apart from the Option<Amount> fields; the integration tests exercise the processor against a real 0.17 Mint with sqlite.
7011eebc lives on branch fix/nutxx-lookup of vnprc/cdk, not upstream main. If that branch is rebased, the rev pin keeps builds reproducible, but the branch should not be deleted until the work lands upstream.

Validation

cargo check --all-targets: clean.
cargo test: 16/16 pass (12 unit + 4 integration).
Toolchain: rustc 1.97.1 (cdk repo nix develop .#stable; matches upstream's rust-toolchain.toml).

Retarget cdk-ehash from CDK 0.16.0 (cashubtc/cdk 1572941d) to CDK 0.17.0 at vnprc/cdk 7011eebc — upstream main plus the NUT-XX mint quote lookup — so the crate and hashpool build against the identical CDK API. - **What changes for a running machine:** nothing by itself — hashpool consumes cdk-ehash pinned to an exact rev and moves that pin in its own PR. - **What stays identical:** the payment processor's behavior; the only upstream break is a field the processor never reads (`amount` became `Option`), wrapped at two test construction sites. - **What proves it:** `cargo check --all-targets` clean and all 16 tests (12 unit + 4 integration) pass against the new rev. - **If it is wrong:** revert the merge; nothing deployed consumes cdk-ehash main directly. Refs vnprc/hashpool#7 (tracking issue); the paired hashpool pin move is PR vnprc/hashpool#8. ### Changes - `Cargo.toml`: `[patch.crates-io]` → `vnprc/cdk` rev `7011eebc` for all seven cdk crates; version reqs `0.16.0` → `0.17.0` (cdk-common, cdk, cdk-sqlite) to match the patched workspace version. - `src/payment.rs`, `tests/integration.rs`: `CustomIncomingPaymentOptions.amount` and `MintQuoteCustomRequest.amount` became `Option<Amount>` upstream; the two construction sites wrap in `Some(...)`. `create_incoming_payment_request` never reads the field, so no behavior change. - `Cargo.lock`: re-resolved against the new rev. ### Risk - 265 commits of upstream CDK drift sit between the old and new pins. For this crate the exposure is the `MintPayment` trait surface, which is unchanged apart from the `Option<Amount>` fields; the integration tests exercise the processor against a real 0.17 `Mint` with sqlite. - `7011eebc` lives on branch `fix/nutxx-lookup` of vnprc/cdk, not upstream main. If that branch is rebased, the rev pin keeps builds reproducible, but the branch should not be deleted until the work lands upstream. ### Validation - `cargo check --all-targets`: clean. - `cargo test`: 16/16 pass (12 unit + 4 integration). - Toolchain: rustc 1.97.1 (cdk repo `nix develop .#stable`; matches upstream's `rust-toolchain.toml`).

vnprc-agent added 1 commit

2026-08-07 22:51:16 +01:00

bump CDK to 0.17.0 at vnprc/cdk 7011eebc (NUT-XX mint quote lookup) 1328180f28

Move the [patch.crates-io] pin from cashubtc/cdk 1572941d (0.16.0) to
vnprc/cdk 7011eebc, the tip of branch fix/nutxx-lookup: upstream main at
23fa905d plus the NUT-XX mint quote lookup endpoint. Hashpool moves its
workspace pins to the same rev in lockstep; this keeps cdk-ehash's local
dev environment on the identical CDK API.

- Cargo.toml: cdk-common/cdk/cdk-sqlite version reqs 0.16.0 -> 0.17.0 to
  match the patched source's workspace version; patch rev 7011eebc
- src/payment.rs, tests/integration.rs: CustomIncomingPaymentOptions.amount
  and MintQuoteCustomRequest.amount became Option<Amount> upstream; wrap
  the two construction sites in Some(). The processor itself never reads
  the field, so no behavior change.
- Cargo.lock: re-resolved against the new rev

cargo check --all-targets clean; all 16 tests pass (12 unit + 4
integration) under rustc 1.97.1.

vnprc-agent referenced this pull request from vnprc/hashpool

2026-08-07 22:51:34 +01:00

bump CDK to 0.17.0 at vnprc/cdk 7011eebc (NUT-XX mint quote lookup) #8

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

You are not authorized to merge this pull request.

View command line instructions