forge: a pull request shown as merged whose commit was not on master #246
Labels
No labels
blocked
bug
decision
duplicate
enhancement
help wanted
invalid
landed?
question
ready-to-merge
stale
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
allod/tools#246
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The forge reported allod/memory#70 as merged while
masterofallod/memorydid not move. The same branch, merged again as allod/memory#71 nineteen minutes later, landed.Evidence
Forge:
{"version":"16.0.2+gitea-1.22.0"}. Times are the forge's, +01:00.06b09c05ded11135739686ed7527e4b2feb5d979onagent/site-serve-notes, cut frommasteratd6460d8bd5bff3bb216672f65294e24babbf4feaAPPROVEDby the owner,official: true,stale: false/pulls/70/reviewsmerged: true,merged_bythe owner,merge_commit_sha06b09c0…, equal to the head,merge_based6460d8…/pulls/70git ls-remote origin refs/heads/masterover SSH printedd6460d8…; aftergit fetch,git merge-base --is-ancestor 06b09c0 origin/masterexited 1;allod.mdonmasterhad none of the changemerged: true, samemerge_commit_sha; no review on it/pulls/71,/pulls/71/reviewsrefs/heads/masteris06b09c0…git ls-remotemasterofallod/memoryis not protected (/branches/master:protected: false,required_approvals: 0). The repository is not a mirror.Every other merged pull request the forge lists was checked the same way: for the most recent 50 closed pull requests of
memory,tools,inventory,archetypes,nexus,vm,deploy,profilesandstrategy, 225 merged in all, eachmerge_commit_shais an ancestor oforigin/master. allod/memory#70 now passes that test too, because allod/memory#71 put the same commit onmaster.Not known
mastermoved at 16:07:43 and moved back, or never moved.