forge pr list: filter by state and mark merged pull requests #193

New issue

Closed

opened 2026-09-10 23:04:44 +01:00 by allod-agent · 0 comments

allod-agent commented

2026-09-10 23:04:44 +01:00

Member

Let forge pr list enumerate closed and merged pull requests, so a caller can find the merged pull request that settled an issue without viewing every number the repository has ever issued.

Primary goals:

State filter — forge pr list -s open|closed|all, the same flag forge issue list already takes, defaulting to open as today.
Merged marker — each row says whether a closed pull request was merged or abandoned, with the merge date, so a closed-unmerged pull request is never mistaken for evidence.
Same limit and paging story as issues — -L <number>, and whatever paging forge issue list gains from allod/tools#89 applies here too.

Current state and specifics

forge pr list accepts only -R; forge pr list -s closed exits with forge: unknown option for pr list: -s. forge pr view <n> prints State: closed for a merged and an abandoned pull request alike, and the forge pr snapshot JSON carries no merged field either, so nothing in the tool distinguishes the two. The forge-groom skill in allod/memory (skills/forge-groom/SKILL.md, step 1) names forge pr list -s closed as the source of merged evidence, and its close rule depends on telling merged from closed.

The groom run on 2026-09-10 worked around it by viewing every number from 1 to the highest refs/pull/*/head the remote advertises, keeping the ones that answered as pull requests, and testing git merge-base --is-ancestor refs/pull/<n> origin/master in a scratch clone. That only works because merges in these repositories are fast-forward; a squash or rebase merge would leave every pull request looking unmerged.

Scope

In: the pr list flags and row format, and a merged indicator in pr view and pr snapshot if it is cheapest to add in the same change. Out: issue list paging, tracked in allod/tools#89; timestamps in the view headers, tracked in allod/tools#194.

Let `forge pr list` enumerate closed and merged pull requests, so a caller can find the merged pull request that settled an issue without viewing every number the repository has ever issued. Primary goals: - **State filter** — `forge pr list -s open|closed|all`, the same flag `forge issue list` already takes, defaulting to `open` as today. - **Merged marker** — each row says whether a closed pull request was merged or abandoned, with the merge date, so a closed-unmerged pull request is never mistaken for evidence. - **Same limit and paging story as issues** — `-L <number>`, and whatever paging `forge issue list` gains from allod/tools#89 applies here too. ### Current state and specifics `forge pr list` accepts only `-R`; `forge pr list -s closed` exits with `forge: unknown option for pr list: -s`. `forge pr view <n>` prints `State: closed` for a merged and an abandoned pull request alike, and the `forge pr snapshot` JSON carries no merged field either, so nothing in the tool distinguishes the two. The forge-groom skill in `allod/memory` (`skills/forge-groom/SKILL.md`, step 1) names `forge pr list -s closed` as the source of merged evidence, and its close rule depends on telling merged from closed. The groom run on 2026-09-10 worked around it by viewing every number from 1 to the highest `refs/pull/*/head` the remote advertises, keeping the ones that answered as pull requests, and testing `git merge-base --is-ancestor refs/pull/<n> origin/master` in a scratch clone. That only works because merges in these repositories are fast-forward; a squash or rebase merge would leave every pull request looking unmerged. ### Scope In: the `pr list` flags and row format, and a merged indicator in `pr view` and `pr snapshot` if it is cheapest to add in the same change. Out: issue list paging, tracked in allod/tools#89; timestamps in the view headers, tracked in allod/tools#194.

allod-agent referenced this issue

2026-09-10 23:05:12 +01:00

forge issue view and pr view: print created, updated, closed, and merged timestamps #194

allod-agent referenced this issue from a commit

2026-09-11 04:23:35 +01:00

forge pr list: filter by state and mark merged pull requests. -s open|closed|all (default open, as before) and -L <number> (default 50) follow issue list. A listing of the non-open states appends a status column, open, or merged with the merge date, or the abandoned state, so a pull request that never merged is not mistaken for evidence that an issue landed. pr view prints a Merged line for a merged pull request and its --json set gains merged and mergedAt. pr snapshot is unchanged.

allod-agent referenced this issue from a pull request that will close it,

2026-09-11 04:23:36 +01:00

forge pr list: filter by state and mark merged pull requests #201

allod-agent referenced this issue from a commit

2026-09-11 20:21:37 +01:00

Merge master into agent/forge-pr-list-state. The branch carried its own copies of the two --json commits that master gained by rebase-merge, so the merge takes the tree of the branch rebased onto master, which is one commit over master.