Remove the allod pm tool #179

Merged

vnprc merged 2 commits from agent/remove-pm into master

2026-09-09 23:28:27 +01:00

allod-agent commented

2026-09-09 21:45:48 +01:00

Member

This removes the allod pm project-board tool, which the owner has declared a failed experiment (last touched 2026-07-27, four commit days in total). After this merges, allod pm is an unknown command like any other word the CLI does not know, and the pm/ directory (the board script, renderer, integrity checker, JSON schema, fixtures, and the two groom and review skill prompts) is gone from the repository. Nothing else changes: allod change, allod patch, and allod pr explain keep their code and usage text. Only pr resolves files through ALLOD_TOOLS_DIR; change and patch are pure Go. The proof is the repository's own gate, nix flake check, which builds the binaries and runs every Go and shell suite, plus a grep of the tree showing no remaining reference to pm. If this turns out to be wrong, revert the single commit; no machine state or data outside the repository is touched, and a deployment's private pm-state checkout is left as it was.

On a deployed machine, with only allod/archetypes#73 merged, the binary still registers pm and falls back to the live ~/work/allod/tools checkout. With only this PR merged, the deployed binary is still built from the old tools revision with the staged tree, so allod pm keeps working in both partial states. Only a source build of this revision without allod/archetypes#73 sees a not-found error.

Refs allod/tools#103
Refs allod/tools#111
Refs allod/tools#133
Refs allod/tools#137
Refs allod/tools#110

Risk

Low. The change is a deletion of one namespace and its tree; the surviving namespaces share only findExecutable, replaceProcess, executableDir, and workDir, all of which delegatePR still uses, so nothing pr-explain needs was removed. Merge allod/archetypes#73 first, then this PR, then bump locks freely; the reverse order leaves a window where advancing the archetypes/allod-tools node in deploy or a flake-update-cascade allod-tools run makes the old pmTools derivation fail on the missing pm tree.

allod/nexus nix/home.nix carries a comment saying pr and pm delegate to bash; a nexus PR updates it.

Validation

nix flake check in the branch worktree: all checks passed (allod, forge, flake-update-cascade builds; allod-parity which runs tests/allod-change.sh, tests/allod-patch.sh, and the three pr-explain suites against the packaged binary; cascade-suites; flake-status-suite; go-checks which runs gofmt, go vet ./..., go test ./..., go vet -tags site ./..., go test -tags site ./...).
The same five Go commands run directly from nix develop: gofmt prints nothing, vet and test pass with and without the site tag (six packages each).
grep -rn "\bpm\b\|delegatePM\|pmTools" --exclude=.git --exclude-dir=.git . prints nothing. pr-explain/, docs/pr-explain.md, and tests/pr-explain/ are untouched and still reference ALLOD_TOOLS_DIR as before.
Noted for the record: tests/allod-change.sh assertion 54 (worktree race) and tests/allod-patch.sh assertion 139 (apply --push calls git push) fail when run directly from nix develop on this VM, but they fail identically on unmodified master and pass inside the sandboxed allod-parity check, so they are an environment issue unrelated to this change.

This removes the `allod pm` project-board tool, which the owner has declared a failed experiment (last touched 2026-07-27, four commit days in total). After this merges, `allod pm` is an unknown command like any other word the CLI does not know, and the `pm/` directory (the board script, renderer, integrity checker, JSON schema, fixtures, and the two groom and review skill prompts) is gone from the repository. Nothing else changes: `allod change`, `allod patch`, and `allod pr explain` keep their code and usage text. Only `pr` resolves files through `ALLOD_TOOLS_DIR`; `change` and `patch` are pure Go. The proof is the repository's own gate, `nix flake check`, which builds the binaries and runs every Go and shell suite, plus a grep of the tree showing no remaining reference to pm. If this turns out to be wrong, revert the single commit; no machine state or data outside the repository is touched, and a deployment's private pm-state checkout is left as it was. On a deployed machine, with only allod/archetypes#73 merged, the binary still registers `pm` and falls back to the live `~/work/allod/tools` checkout. With only this PR merged, the deployed binary is still built from the old tools revision with the staged tree, so `allod pm` keeps working in both partial states. Only a source build of this revision without allod/archetypes#73 sees a not-found error. Refs allod/tools#103 Refs allod/tools#111 Refs allod/tools#133 Refs allod/tools#137 Refs allod/tools#110 ## Risk Low. The change is a deletion of one namespace and its tree; the surviving namespaces share only `findExecutable`, `replaceProcess`, `executableDir`, and `workDir`, all of which `delegatePR` still uses, so nothing pr-explain needs was removed. Merge allod/archetypes#73 first, then this PR, then bump locks freely; the reverse order leaves a window where advancing the `archetypes/allod-tools` node in deploy or a `flake-update-cascade allod-tools` run makes the old `pmTools` derivation fail on the missing pm tree. allod/nexus `nix/home.nix` carries a comment saying pr and pm delegate to bash; a nexus PR updates it. ## Validation - `nix flake check` in the branch worktree: all checks passed (`allod`, `forge`, `flake-update-cascade` builds; `allod-parity` which runs `tests/allod-change.sh`, `tests/allod-patch.sh`, and the three pr-explain suites against the packaged binary; `cascade-suites`; `flake-status-suite`; `go-checks` which runs gofmt, `go vet ./...`, `go test ./...`, `go vet -tags site ./...`, `go test -tags site ./...`). - The same five Go commands run directly from `nix develop`: gofmt prints nothing, vet and test pass with and without the `site` tag (six packages each). - `grep -rn "\bpm\b\|delegatePM\|pmTools" --exclude=.git --exclude-dir=.git .` prints nothing. `pr-explain/`, `docs/pr-explain.md`, and `tests/pr-explain/` are untouched and still reference `ALLOD_TOOLS_DIR` as before. - Noted for the record: `tests/allod-change.sh` assertion 54 (worktree race) and `tests/allod-patch.sh` assertion 139 (`apply --push` calls git push) fail when run directly from `nix develop` on this VM, but they fail identically on unmodified master and pass inside the sandboxed `allod-parity` check, so they are an environment issue unrelated to this change.

allod-agent added 1 commit

2026-09-09 21:45:48 +01:00

Remove the allod pm tool 79f09cf2fa

allod-agent referenced this pull request

2026-09-09 21:47:58 +01:00

Port the PM board tool to Go as allod pm (first bash-to-Go carve-off) #103

allod-agent referenced this pull request

2026-09-09 21:47:58 +01:00

pm.html: make a project's dependency structure viewable by a human #111

allod-agent referenced this pull request

2026-09-09 21:47:59 +01:00

pm scripts pass the token in argv and swallow failed requests #133

allod-agent referenced this pull request

2026-09-09 21:48:00 +01:00

allod pm: install surface, workflow cutover, retirement cleanup #137

allod-agent referenced this pull request

2026-09-09 21:48:00 +01:00

Add a bulk issue-snapshot read to forge for PM render and groom #110

allod-agent referenced this pull request

2026-09-09 21:57:37 +01:00

forge: read the API token only from the token file #178

allod-agent referenced this pull request

2026-09-09 21:57:38 +01:00

forge: read the API token only from the token file #178

allod-agent referenced this pull request from allod/archetypes

2026-09-09 21:59:38 +01:00

Drop the allod pm tool tree from the dev home composition #73

allod-agent added 1 commit

2026-09-09 21:59:39 +01:00

pr-explain: state how the allod CLI finds this directory 53540fd66d

The header claimed the CLI resolves it from the Nix store through
ALLOD_TOOLS_DIR; no consumer ever staged pr-explain into the store, and
every machine finds it in the live checkout. Answers the review pass on
PR 179. Refs allod/tools#137

allod-agent referenced this pull request from allod/strategy

2026-09-09 21:59:45 +01:00

Drop pm from the bash-to-Go migration plan #50

allod-agent referenced this pull request from allod/nexus

2026-09-09 21:59:49 +01:00

home: only the pr command still delegates to bash #43