allod/tools
Watch
2
0
Fork
You've already forked tools
 0
Code Issues 27 Pull requests Projects Releases Packages Wiki Activity Actions

Port forge pr snapshot to Go #156

Merged
vnprc merged 1 commit from agent/forge-snapshot-port into master 2026-08-24 22:42:44 +01:00
Conversation 1 Commits 1 Files changed 6 +507
allod-agent commented 2026-08-24 21:34:27 +01:00
Member
Copy link

Summary

  • implement forge pr snapshot in the Go CLI with the Bash command's versioned JSON projection
  • preserve repository/URL binding, object-ID, ref, fork, and AGit head-ref validation
  • port all 19 Bash snapshot scenarios into the Go httptest suite and add command help/argument coverage

User impact

No intentional interface change. The Go binary now supports the snapshot command used by agent archetype launchers; the Bash implementation remains available until both downstream cutovers are deployed.

Validation

  • go test ./...
  • go vet ./...
  • all tests/forge/*.sh suites (including 19 snapshot scenarios)
  • nix build 'path:.#forge'
  • nix flake check 'path:.'
  • live read-only byte-for-byte comparisons between Bash and the built Go binary for --help, pr list, issue list, and pr snapshot 136

Residual risk

R3: this adds a machine-readable shared interface ahead of the profiles and host cutovers. Validation is intentionally fail-closed and is pinned by direct ports of the Bash fixtures plus a live Forgejo snapshot comparison. Deployment remains human-gated; this change alone does not alter the installed forge.

Rollback

Revert this PR or keep downstream pins on the existing Bash wrapper. Do not remove the Bash source until both the profiles and nexus cutovers have been rebuilt and verified.

Dependencies and follow-up

This must merge before updating the allod-tools pins in allod/archetypes#40 and allod/nexus#25. Those cutovers, human rebuild verification, and eventual Bash retirement remain tracked in allod/tools#155.

Refs allod/tools#155
Refs allod/tools#98

## Summary - implement `forge pr snapshot` in the Go CLI with the Bash command's versioned JSON projection - preserve repository/URL binding, object-ID, ref, fork, and AGit head-ref validation - port all 19 Bash snapshot scenarios into the Go `httptest` suite and add command help/argument coverage ## User impact No intentional interface change. The Go binary now supports the snapshot command used by agent archetype launchers; the Bash implementation remains available until both downstream cutovers are deployed. ## Validation - `go test ./...` - `go vet ./...` - all `tests/forge/*.sh` suites (including 19 snapshot scenarios) - `nix build 'path:.#forge'` - `nix flake check 'path:.'` - live read-only byte-for-byte comparisons between Bash and the built Go binary for `--help`, `pr list`, `issue list`, and `pr snapshot 136` ## Residual risk R3: this adds a machine-readable shared interface ahead of the profiles and host cutovers. Validation is intentionally fail-closed and is pinned by direct ports of the Bash fixtures plus a live Forgejo snapshot comparison. Deployment remains human-gated; this change alone does not alter the installed `forge`. ## Rollback Revert this PR or keep downstream pins on the existing Bash wrapper. Do not remove the Bash source until both the profiles and nexus cutovers have been rebuilt and verified. ## Dependencies and follow-up This must merge before updating the `allod-tools` pins in allod/archetypes#40 and allod/nexus#25. Those cutovers, human rebuild verification, and eventual Bash retirement remain tracked in allod/tools#155. Refs allod/tools#155 Refs allod/tools#98
Refs allod/tools#155.
Refs allod/tools#98.
vnprc approved these changes 2026-08-24 22:42:37 +01:00
vnprc merged commit 5649cec426 into master 2026-08-24 22:42:44 +01:00
vnprc deleted branch agent/forge-snapshot-port 2026-08-24 22:42:45 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
vnprc
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
allod/tools!156
No description provided.