Review guidance should cover generated lifecycle artifacts #1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The allod-dev provisioning failure exposed a review and memory gap: plan review and acceptance-test guidance covered source evaluation and structural checks, but did not explicitly require inspecting generated lifecycle artifacts or absent-resource paths.
The concrete failure was a NixOS activation snippet that used
exit 0when/root/.git-credentialswas absent. Because NixOS activation snippets are concatenated into one generatedactivatescript, that exited activation before/run/current-systemwas linked, causingnixos-anywhereto fail and leaving the VM unbootable.Update shared memory so future plan reviews and dev plans cover generated activation scripts, systemd units, wrappers, provisioning phases, and negative paths for missing optional credentials/secrets/files. Also fix the provisioning gotcha that previously recommended an ambiguous "early exit" pattern for activation scripts.