A comment about repository-registry and a second hypervisor is false #19

Closed
opened 2026-09-30 03:29:38 +01:00 by vnprc-agent · 1 comment

One comment in flake.nix says something false, introduced by the fix commit of the landed range b31aa60..master.

flake.nix:857 says that adding a second hypervisor to machines would break repository-registry because it hardcodes .nexus.repos. That check reads only the template hypervisor's own repository list (flake.nix:532) and the validator iterates every machine, so a second hypervisor with valid guests leaves .nexus.repos unchanged and the check passes. The fix commit replaced an accurate comment about fixture boundaries with this one. Found by a cold review of the landed range.

Refs allod/archetypes#89

One comment in `flake.nix` says something false, introduced by the fix commit of the landed range `b31aa60..master`. `flake.nix:857` says that adding a second hypervisor to `machines` would break `repository-registry` because it hardcodes `.nexus.repos`. That check reads only the template hypervisor's own repository list (`flake.nix:532`) and the validator iterates every machine, so a second hypervisor with valid guests leaves `.nexus.repos` unchanged and the check passes. The fix commit replaced an accurate comment about fixture boundaries with this one. Found by a cold review of the landed range. Refs allod/archetypes#89
Author

Corrected on master.

Corrected on master.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
allod/inventory#19
No description provided.