Drop the transitional mkDefault from the dev VM forge SSH entry #82
Labels
No labels
blocked
bug
decision
duplicate
enhancement
help wanted
invalid
landed?
question
ready-to-merge
stale
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
allod/archetypes#82
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Drop the transitional
lib.mkDefaultfrom the dev VM's rendered forge SSH entry, so a stray profile copy of that block is a type clash at evaluation rather than a silent winner. Part of allod/strategy#56; the trigger named there is met: a deploy lock now exists in which no profile input defines the block.Primary goals:
modules/dev-ssh-forge.nixsetsIdentityFileat normal priority; the comment explaining the transition goes with it.ssh-settingscheck's legacy-profile fixture flips from "the profile's identity file wins" to "evaluation fails with a conflicting-type error", and the deleted-profile fixture keeps proving the framework's key is the one rendered.Current state and specifics
modules/dev-ssh-forge.nixrendersprograms.ssh.settings.<forgeHost>withIdentityFile = lib.mkDefault "~/.ssh/${sshKeyName}", so that a profile still carrying the block (allod/profiles before fa37849, and deployments' private profiles) won without a clash while the two sides landed in either order. Both sides have landed: allod/profiles fa37849 deleted the public copy, and deployments have deleted theirs and taken both into their deploy locks.checks/ssh-settings.nixpins the transitional behaviour with a fixture that defines the block through legacymatchBlocksbeside the module and asserts the profile's key wins; that fixture becomes the sabotage fixture for the clash.Scope
In:
modules/dev-ssh-forge.nix,checks/ssh-settings.nix. Out: the hypervisor's address book translation, and any change toidentity.sshHosts.