Remove the microvm guest runtime from the framework #71
No reviewers
Labels
No labels
blocked
bug
decision
duplicate
enhancement
help wanted
invalid
landed?
question
ready-to-merge
stale
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
allod/archetypes!71
Loading…
Reference in a new issue
No description provided.
Delete branch "agent/microvm-withdrawal"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The microvm runtime is gone from this repo. No running machine changes: every machine in the example fleet composes the libvirt guest exactly as before, and a fleet diff from allod/deploy against this branch reports all four machines unchanged. What goes is code only a microvm machine would have used, and no inventory ever declared one. Every remaining check builds green. This PR leaves the lock alone, so it moves nothing on its own; if a machine changes later, the deploy lock bump at the end of the sequence is the PR to revert.
Refs allod/strategy#46. Merge order: first of the sequence posted on that issue. The nexus, vm and inventory removals follow it, and this repo's lock advances in a later PR once nothing here reads what they remove.
What changes
checks/microvm-{credentials,fleet-wiring,host-join,sshd-boot}.nix,checks/qemu-command.nix,modules/microvm-*, and inflake.nixthe volumes, interfaces, credentials and host/guest join regions,fleetMicrovmGuests, the guest-set argument ofmkHypervisor, and everyruntime == "microvm"gate in the three builders.guestModuleForkeeps its total table over inventory's enum, now one member; the unmapped-runtime negative inruntime-module-selectionstill pins it.runtime-module-selectiondrops its three microvm fixtures and everything only they exercised (volume, interface and address scanners, the QEMU reconstruction). It still compares every guest machine's marker against its inventory fact, forces every guest toplevel, refuses a hypervisor that composes a guest module, and delegates enum coverage to inventory'sruntime-fact-mutations.vm-facts-coherenceandvm-facts-negativesabotage with a literal outside the enum instead of the other member.credential-profiles,netrc-activationanddev-forge-opt-outdrop the runtime filters that only existed to skip microvm machines, restoring the shape they had before: a target is measured whenever this repo builds its machine.modules/pi-provider-lifecycle.nixno longer takes aruntimeargument and deploysage.secretsunconditionally.flake.lockuntouched.Risk
lib.piProviderLifecycle.mkNixosModulelost itsruntimeparameter, so an out-of-tree caller that still passes one fails at evaluation rather than silently. No public caller does.Validation
nix build .#checks.x86_64-linux.<name>one attribute at a time, all green: agent-vm-status, composed-layer-smoke, credential-profiles, dev-forge-opt-out, netrc-activation, pi-integration, pi-provider-lifecycle, profile-definition-contracts, public-host, runtime-module-selection, site-content, static-site, vm-facts-coherence, vm-facts-negative.fleet-diff --override archetypes=f6aba2d576e2cfd225c2016e0baba179b5aff539 --expect-nonefrom allod/deploy: allod-dev, installer, nexus, privacy-1 all unchanged; expectation matches.grep -ri microvmover the tree finds onlyflake.lock.